Check for invalid characters prior to rename #5193
Conversation
On Windows platforms, rename operations containing ':' are problematic since the operation succeeds, but creates an unintended "alternate data stream" that gives the user the impression their file contents have been deleted. This change performs cursory validation of the destination name on platforms in which issues can occur. Currently, non-Windows systems don't require this level of validation. Fixes jupyter#5190
|
|
||
| for char in invalid_chars: | ||
| if char in path: | ||
| raise web.HTTPError(400, u"Path '{}' contains invalid characters {} relative to its platform. " |
There was a problem hiding this comment.
How about Path '{}' contains characters that are invalid for the filesystem. Path names on this filesystem cannot contain any of the following characters: {}.? I'm trying to make the message simpler, though it seems a little less actionable too (though in the validation method, it's not clear exactly who is calling us and what the recovery procedure should be...)
There was a problem hiding this comment.
Thank you - that reads much more cleanly. Here's a screen shot with the update:
Previously, I was taking advantage of the parenthesis that sets print with. That could now be argued as unnecessary. If there's an easy pythonic way to remove those, I can do that - otherwise it seems okay to me.
There was a problem hiding this comment.
You could just define it as a string instead of a tuple.
jasongrout
left a comment
jasongrout
left a comment
There was a problem hiding this comment.
The code looks good, though I can't test on a mac very well. I wrote an inline comment about the error message for consideration.
kevin-bates
force-pushed
the
validate-rename
branch
from
f0f627d to
2d3d347
Compare
3 participants
On Windows platforms, rename operations containing ':' are problematic
since the operation succeeds, but creates an unintended "alternate data
stream" that gives the user the impression their file contents have been
deleted. This change performs cursory validation of the destination
name on platforms in which issues can occur. Currently, non-Windows
systems don't require this level of validation.
When an invalid character is encountered during the rename operation, a message similar to the following will occur:
Fixes #5190